Review three pull requests
Filed under Airbnb
Free read 3 of 3Read the PR title, description and file list first to understand intent before reading any lines. Note what is missing from the description (tests, rollout plan).
The question
You are given three pull requests to review as if you were a senior engineer on the team. For each one, read the diff, work out what the change is supposed to do, find defects and risks, and write the review comments you would leave, deciding whether you would approve, request changes or comment only. Note: the contents of the three pull requests were not reported, so this describes the format of the round rather than specific code.
Approach
Read the PR title, description and file list first to understand intent before reading any lines. Note what is missing from the description (tests, rollout plan).
Look for logic errors, off-by-one and null handling, error paths, concurrency, security (injection, auth), performance on large inputs, backwards compatibility and data migrations.
Then check tests, naming, structure, duplication, readability and documentation. Label nitpicks as such so the author can tell blockers from preferences.
Write specific, kind comments with a reason and a suggested fix, separate blocking from non-blocking, and give a clear overall verdict per PR. A strong answer shows prioritisation and empathy for the author.
Tips
- What they are testing: Whether you can find real correctness problems quickly and prioritise them over style, communicate feedback constructively and reason about maintainability, tests and edge cases.
- Common mistake: Spending the time on naming and formatting nitpicks while missing logic errors, race conditions, missing error handling or missing tests, or writing comments that are blunt and give no reason or fix.
Related Airbnb questions
Collected from public candidate posts and coding forums. Updated Nov 2026.